Change Stacked Area chart for Area chart for the Virtual Machine CPU States #18333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
force-pushed
the
bz-1527695
branch
from
c41c9e6
to
24c0313
Compare
|
@h-kataria there are more Stacked Area charts, do you think I should also change them for the Area? |
|
@PanSpagetka if those are having the similar issue, then i would say let's change those as well. |
|
Checked commits PanSpagetka/manageiq@24c0313~...0797f06 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@martinpovolny is there a label we use for charts related changes? |
|
We have "charts" but only on the frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Stacked Area chart for Area chart for the Virtual Machine CPU States chart.
Now the values should not be aggregated.
Screenshots [Optional]
Before:
After:
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1527695
Steps for Testing/QA [Optional]